From: Alexander Kornienko Date: Fri, 28 Nov 2014 17:31:51 +0000 (+0000) Subject: [clang-tidy] More tests for the google-explicit-constructor check X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=18bc3bf830a88fc7d745a97c2e9ff5288628da5c;p=platform%2Fupstream%2Fllvm.git [clang-tidy] More tests for the google-explicit-constructor check llvm-svn: 222924 --- diff --git a/clang-tools-extra/test/clang-tidy/google-explicit-constructor.cpp b/clang-tools-extra/test/clang-tidy/google-explicit-constructor.cpp index 7866df6..fec8deb 100644 --- a/clang-tools-extra/test/clang-tidy/google-explicit-constructor.cpp +++ b/clang-tools-extra/test/clang-tidy/google-explicit-constructor.cpp @@ -36,7 +36,6 @@ namespace std { struct A { A() {} A(int x, int y) {} - A(std::initializer_list list1) {} explicit A(void *x) {} explicit A(void *x, void *y) {} @@ -45,10 +44,6 @@ struct A { // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: copy constructor should not be declared explicit [google-explicit-constructor] // CHECK-FIXES: {{^ }}A(const A& a) {} - explicit A(std::initializer_list list2) {} - // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: initializer-list constructor should not be declared explicit [google-explicit-constructor] - // CHECK-FIXES: {{^ }}A(std::initializer_list list2) {} - A(int x1) {} // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: single-argument constructors must be explicit [google-explicit-constructor] // CHECK-FIXES: {{^ }}explicit A(int x1) {} @@ -57,3 +52,29 @@ struct A { // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: single-argument constructors must be explicit // CHECK-FIXES: {{^ }}explicit A(double x2, double y = 3.14) {} }; + +struct B { + B(std::initializer_list list1) {} + B(const std::initializer_list &list2) {} + B(std::initializer_list &&list3) {} + + explicit B(::std::initializer_list list4) {} + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: initializer-list constructor should not be declared explicit [google-explicit-constructor] + // CHECK-FIXES: {{^ }}B(::std::initializer_list list4) {} + + explicit B(const ::std::initializer_list &list5) {} + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: initializer-list constructor should not be declared explicit [google-explicit-constructor] + // CHECK-FIXES: {{^ }}B(const ::std::initializer_list &list5) {} + + explicit B(::std::initializer_list &&list6) {} + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: initializer-list constructor should not be declared explicit [google-explicit-constructor] + // CHECK-FIXES: {{^ }}B(::std::initializer_list &&list6) {} +}; + +using namespace std; + +struct C { + C(initializer_list list1) {} + C(const initializer_list &list2) {} + C(initializer_list &&list3) {} +};