From: Juan Hoyos <juan.hoyos@microsoft.com>
Date: Fri, 30 Apr 2021 19:35:38 +0000 (-0700)
Subject: Remove file-dedup workaround (#2233)
X-Git-Tag: submit/tizen/20210909.063632~15^2~67
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=18a8e986ddf28ee3c950b5acf00abc652d87be74;p=platform%2Fcore%2Fdotnet%2Fdiagnostics.git

Remove file-dedup workaround (#2233)
---

diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets
index d7264ef75..9759f0bb7 100644
--- a/src/Directory.Build.targets
+++ b/src/Directory.Build.targets
@@ -11,22 +11,6 @@
     <EmbeddedFiles Include="$(GeneratedAssemblyInfoFile)"/>
   </ItemGroup>
 
-  <!-- This is an ugly workaround needed to be able to do r2r/single file on packages that reference TraceEvent as the package's props inject a double
-  write to the same relative path. This is related to https://github.com/microsoft/perfview/issues/1002 -->
-  <Target Name="RemoveDupeAssemblies"
-          Condition="'$(PublishSingleFile)' == 'true'"
-          AfterTargets="ComputeResolvedFilesToPublishList"
-          BeforeTargets="CopyFilesToPublishDirectory">
-      
-    <PropertyGroup>
-      <ExcludedTraceEventPath>$([MSBuild]::NormalizeDirectory($(PkgMicrosoft_Diagnostics_Tracing_TraceEvent), 'lib/netstandard1.6'))</ExcludedTraceEventPath>
-    </PropertyGroup>
-    <ItemGroup>
-      <ResolvedFileToPublish Condition="$([MSBuild]::NormalizePath(%(ResolvedFileToPublish.Identity)).StartsWith($(ExcludedTraceEventPath)))"
-                             ExcludeFromSingleFile="true"/>
-    </ItemGroup>
-  </Target>
-
   <!-- We need this for the binplacing for testing assets.
   This should be removed at some point as it's brittle (harcodes versions and creates native-managed coupling). -->
   <Target Name="_PublishPackageReferences"
diff --git a/src/Tools/Directory.Build.targets b/src/Tools/Directory.Build.targets
index ddd6364b6..8a7fdb7f1 100644
--- a/src/Tools/Directory.Build.targets
+++ b/src/Tools/Directory.Build.targets
@@ -36,18 +36,4 @@
     </ItemGroup>
     <Message Importance="Low" Text="@(FilesInBundleToSign)"/>
   </Target>
-
-  <Target Name="PrepareForBundling"
-          BeforeTargets="GenerateSingleFileBundle"
-          AfterTargets="_ComputeFilesToBundle"
-          DependsOnTargets="RemoveDupeAssemblies" />
-
-  <!-- Workaround for https://github.com/microsoft/perfview/issues/1002 -->
-  <Target Name="RemoveDupeAssemblies">
-    <ItemGroup>
-      <_FilesToBundle Remove="$(PkgMicrosoft_Diagnostics_Tracing_TraceEvent)\lib\netstandard1.6\Dia2Lib.dll" />
-      <_FilesToBundle Remove="$(PkgMicrosoft_Diagnostics_Tracing_TraceEvent)\lib\netstandard1.6\OSExtensions.dll" />
-      <_FilesToBundle Remove="$(PkgMicrosoft_Diagnostics_Tracing_TraceEvent)\lib\netstandard1.6\TraceReloggerLib.dll" />
-    </ItemGroup>
-  </Target>
 </Project>
\ No newline at end of file