From: Mario Schuknecht Date: Sun, 16 Nov 2014 20:21:45 +0000 (+0100) Subject: usb: gadget: net2280: Fix superspeed dma_done() X-Git-Tag: v4.14-rc1~6297^2~32^2~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=18a4e65f229aec8ac23a036ff734864eefe4b89d;p=platform%2Fkernel%2Flinux-rpi.git usb: gadget: net2280: Fix superspeed dma_done() Parameter three in function call dma_done() is incorrect. Move use of variable 'tmp' after if-condition. Signed-off-by: Mario Schuknecht Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c index c491794..d6411e0 100644 --- a/drivers/usb/gadget/udc/net2280.c +++ b/drivers/usb/gadget/udc/net2280.c @@ -1118,10 +1118,10 @@ static void scan_dma_completions(struct net2280_ep *ep) break; } else if (!ep->is_in && (req->req.length % ep->ep.maxpacket) != 0) { - tmp = readl(&ep->regs->ep_stat); if (ep->dev->quirks & PLX_SUPERSPEED) return dma_done(ep, req, tmp, 0); + tmp = readl(&ep->regs->ep_stat); /* AVOID TROUBLE HERE by not issuing short reads from * your gadget driver. That helps avoids errata 0121, * 0122, and 0124; not all cases trigger the warning.