From: Matteo Facchinetti Date: Wed, 8 Oct 2014 14:24:33 +0000 (+0200) Subject: mmc: mxcmmc: fix the default value for available voltages into mxcmci_probe X-Git-Tag: v4.14-rc1~6400^2~122 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=18a098063592e4341bfb904ae9f4e41c08c74a63;p=platform%2Fkernel%2Flinux-rpi.git mmc: mxcmmc: fix the default value for available voltages into mxcmci_probe If available voltages are not given, mmc_regulator_get_supply() function returns 0 and mxcmmc driver doesn't set a value for ocr_avail mask. In accordance with the comment in platform_data/mmc-mxcmmc.h, fix it, assuming MMC_VDD_32_33 | MMC_VDD_33_34 as default value. Signed-off-by: Matteo Facchinetti Reviewed-by: Sascha Hauer Signed-off-by: Ulf Hansson --- diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index 536a898..5316d9b 100644 --- a/drivers/mmc/host/mxcmmc.c +++ b/drivers/mmc/host/mxcmmc.c @@ -1077,12 +1077,14 @@ static int mxcmci_probe(struct platform_device *pdev) dat3_card_detect = true; ret = mmc_regulator_get_supply(mmc); - if (ret) { - if (pdata && ret != -EPROBE_DEFER) - mmc->ocr_avail = pdata->ocr_avail ? : - MMC_VDD_32_33 | MMC_VDD_33_34; + if (ret == -EPROBE_DEFER) + goto out_free; + + if (!mmc->ocr_avail) { + if (pdata && pdata->ocr_avail) + mmc->ocr_avail = pdata->ocr_avail; else - goto out_free; + mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34; } if (dat3_card_detect)