From: Tony Cheng Date: Wed, 12 Jul 2017 13:02:54 +0000 (-0400) Subject: drm/amd/display: change order of HUBP and MPC disable according to HW guide X-Git-Tag: v4.19~2140^2~23^2~329 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=189f73e32e9a7fc5ac62f244b66f8b41a78803c7;p=platform%2Fkernel%2Flinux-rpi.git drm/amd/display: change order of HUBP and MPC disable according to HW guide blank hubp first before disconnect MPC Signed-off-by: Tony Cheng Reviewed-by: Eric Yang Acked-by: Harry Wentland Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c index ac0d62c..0e90e6c 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c @@ -477,9 +477,14 @@ static void reset_front_end( if (mpcc->opp_id == 0xf) return; - mi->funcs->dcc_control(mi, false, false); tg->funcs->lock(tg); + mi->funcs->dcc_control(mi, false, false); + mi->funcs->set_blank(mi, true); + REG_WAIT(DCHUBP_CNTL[fe_idx], + HUBP_NO_OUTSTANDING_REQ, 1, + 1, 200); + mpcc_cfg.opp_id = 0xf; mpcc_cfg.top_dpp_id = 0xf; mpcc_cfg.bot_mpcc_id = 0xf; @@ -491,8 +496,7 @@ static void reset_front_end( REG_WAIT(OTG_GLOBAL_SYNC_STATUS[tg->inst], VUPDATE_NO_LOCK_EVENT_OCCURRED, 1, 20000, 200000); mpcc->funcs->wait_for_idle(mpcc); - mi->funcs->set_blank(mi, true); - REG_WAIT(DCHUBP_CNTL[fe_idx], HUBP_NO_OUTSTANDING_REQ, 1, 20000, 200000); + REG_UPDATE(HUBP_CLK_CNTL[fe_idx], HUBP_CLOCK_ENABLE, 0); REG_UPDATE(DPP_CONTROL[fe_idx], DPP_CLOCK_ENABLE, 0); diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c index 1c9d5e9..9875d81 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c @@ -117,7 +117,9 @@ static void dcn10_mpcc_wait_idle(struct mpcc *mpcc) { struct dcn10_mpcc *mpcc10 = TO_DCN10_MPCC(mpcc); - REG_WAIT(MPCC_STATUS, MPCC_BUSY, 0, 1000, 1000); + REG_WAIT(MPCC_STATUS, + MPCC_BUSY, 0, + 1000, 1000); }