From: Steffen Mueller Date: Fri, 11 Feb 2011 21:52:30 +0000 (+0100) Subject: Reinstate prototype default and warning about invalid prototypes X-Git-Tag: accepted/trunk/20130322.191538~3330^2~42 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=186329e00d0e254120e6755aed2cc4f798097756;p=platform%2Fupstream%2Fperl.git Reinstate prototype default and warning about invalid prototypes --- diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm index ee4524d..6e1d36d 100644 --- a/dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm +++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/Typemaps.pm @@ -810,11 +810,10 @@ sub _parse { my($type, $kind, $proto) = /^(.*?\S)\s+(\S+)\s*($ExtUtils::ParseXS::Constants::PrototypeRegexp*)$/o or warn("Warning: File '$filename' Line $lineno '$line' TYPEMAP entry needs 2 or 3 columns\n"), next; - #$proto = '' if not $proto; # prototype defaults to '$' - #$proto = '$' unless $proto; - #warn("Warning: File '$filename' Line $lineno '$line' Invalid prototype '$proto'\n") - # unless _valid_proto_string($proto); + $proto = '$' unless $proto; + warn("Warning: File '$filename' Line $lineno '$line' Invalid prototype '$proto'\n") + unless _valid_proto_string($proto); $self->add_typemap( ExtUtils::Typemaps::Type->new( xstype => $kind, proto => $proto, ctype => $type