From: Chris Michael Date: Mon, 11 Dec 2017 19:47:14 +0000 (-0500) Subject: elementary: Fix resource leak X-Git-Tag: submit/sandbox/upgrade/efl120/20180319.053334~1221 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=18429454326150e45560354f19c553694ba5b45e;p=platform%2Fupstream%2Fefl.git elementary: Fix resource leak Coverity reports a resource leak here. According to eina_strbuf documentation, the result of eina_strbuf_release should be free'd when not needed anymore. Fixes Coverity CID1383549 @fix Signed-off-by: Chris Michael --- diff --git a/src/lib/elementary/efl_ui_panes.c b/src/lib/elementary/efl_ui_panes.c index b98a1ee..f215387 100644 --- a/src/lib/elementary/efl_ui_panes.c +++ b/src/lib/elementary/efl_ui_panes.c @@ -390,18 +390,22 @@ _efl_ui_panes_efl_canvas_group_group_add(Eo *obj, Efl_Ui_Panes_Data *_pd EINA_UN { ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd); EFL_UI_PANES_DATA_GET(obj, sd); + char *group; if (!elm_widget_theme_klass_get(obj)) elm_widget_theme_klass_set(obj, "panes"); efl_canvas_group_add(efl_super(obj, MY_CLASS)); elm_widget_sub_object_parent_add(obj); + group = _efl_ui_panes_theme_group_get(obj, sd); if (!elm_widget_theme_object_set(obj, wd->resize_obj, elm_widget_theme_klass_get(obj), - _efl_ui_panes_theme_group_get(obj, sd), + group, elm_widget_theme_style_get(obj))) CRI("Failed to set layout!"); + free(group); + elm_panes_content_left_size_set(obj, 0.5); edje_object_signal_callback_add