From: Linus Walleij Date: Mon, 9 Dec 2013 08:26:01 +0000 (+0100) Subject: pinctrl: make the MSM SoC driver depend on OF X-Git-Tag: accepted/tizen/common/20141203.182822~769^2~50^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=18334c8e18b2cea1c5c1ad4103ea1bf359a21775;p=platform%2Fkernel%2Flinux-arm64.git pinctrl: make the MSM SoC driver depend on OF We had a compilation failure on x86_64 due to missing OF support as this was an implicit dependency. Add an explicit dependency on OF and OF_IRQ on the SoC driver. Cc: Bjorn Andersson Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Total failure with older approaches: what we need to do is have the *SoC subdriver* depend on OF and OF_IRQ. This is because the placeholder bool PINCTRL_MSM cannot cascade its dependencies when a subdriver selects it, Kconfig is smart but not that smart. ChangeLog v1->v2: - OK so "depends on OF" did not work here let's try to simply select OF and OF_IRQ for this then? It's one of those "warning: (PINCTRL_MSM8X74) selects PINCTRL_MSM which has unmet direct dependencies (PINCTRL && OF)" that I simply cannot find my way out of :-/ --- diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 06e057b..30fcb89 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -211,6 +211,7 @@ config PINCTRL_MSM config PINCTRL_MSM8X74 bool "Qualcomm 8x74 pin controller driver" + depends on OF && OF_IRQ select PINCTRL_MSM config PINCTRL_NOMADIK