From: Hans Verkuil <hverkuil@xs4all.nl>
Date: Mon, 21 Nov 2016 13:59:20 +0000 (-0200)
Subject: [media] vpfe_capture: fix compiler warning
X-Git-Tag: v4.14-rc1~332^2~1047
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1827bdc7b141859a1eb9d2d45bb923ea7252774a;p=platform%2Fkernel%2Flinux-rpi.git

[media] vpfe_capture: fix compiler warning

davinci/vpfe_capture.c: In function 'vpfe_probe':
davinci/vpfe_capture.c:1992:9: warning: 'ret' may be used uninitialized
in this function [-Wmaybe-uninitialized]
   return ret;
          ^~~

This is indeed correct, so if the kmalloc fails set ret to -ENOMEM.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---

diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
index 6c41782..bc2c62b 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -1847,8 +1847,10 @@ static int vpfe_probe(struct platform_device *pdev)
 
 	/* Allocate memory for ccdc configuration */
 	ccdc_cfg = kmalloc(sizeof(*ccdc_cfg), GFP_KERNEL);
-	if (!ccdc_cfg)
+	if (!ccdc_cfg) {
+		ret = -ENOMEM;
 		goto probe_free_dev_mem;
+	}
 
 	mutex_lock(&ccdc_lock);