From: Dan Carpenter <error27@gmail.com>
Date: Sat, 13 Mar 2010 11:14:22 +0000 (+0300)
Subject: tomoyo: fix potential use after free
X-Git-Tag: v2.6.34-rc2~39
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=181427a7e01beab76c789414334375839f026128;p=platform%2Fkernel%2Flinux-stable.git

tomoyo: fix potential use after free

The original code returns a freed pointer.  This function is expected to
return NULL on errors.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: James Morris <jmorris@namei.org>
---

diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c
index ff51f10..ef89947 100644
--- a/security/tomoyo/common.c
+++ b/security/tomoyo/common.c
@@ -886,6 +886,7 @@ static struct tomoyo_profile *tomoyo_find_or_assign_new_profile(const unsigned
 	ptr = kmalloc(sizeof(*ptr), GFP_KERNEL);
 	if (!tomoyo_memory_ok(ptr)) {
 		kfree(ptr);
+		ptr = NULL;
 		goto ok;
 	}
 	for (i = 0; i < TOMOYO_MAX_CONTROL_INDEX; i++)