From: pr.jung <pr.jung@samsung.com>
Date: Wed, 20 Sep 2017 02:49:40 +0000 (+0900)
Subject: DD_LIST_FOREACH_SAFE should be used when there is node remove operation from list.
X-Git-Tag: accepted/tizen/unified/20171019.060836^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=17dbfca55b15268e7e0ca171e34070af60ad650c;p=platform%2Fcore%2Fsystem%2Flibstorage.git

DD_LIST_FOREACH_SAFE should be used when there is node remove operation from list.

Change-Id: I807635a8959bdc66a26f7b6544e01c56a0bcbdd5
Signed-off-by: pr.jung <pr.jung@samsung.com>
---

diff --git a/src/storage-external-dbus.c b/src/storage-external-dbus.c
index be20d3f..dcd1e9e 100755
--- a/src/storage-external-dbus.c
+++ b/src/storage-external-dbus.c
@@ -367,6 +367,7 @@ void storage_ext_unregister_device_change(storage_ext_changed_cb func)
 	GDBusConnection *conn;
 	struct storage_ext_callback *callback;
 	dd_list *elem;
+	dd_list *elem_n;
 
 	if (!func)
 		return;
@@ -379,7 +380,7 @@ void storage_ext_unregister_device_change(storage_ext_changed_cb func)
 //LCOV_EXCL_STOP
 	}
 
-	DD_LIST_FOREACH(changed_list, elem, callback) {
+	DD_LIST_FOREACH_SAFE(changed_list, elem, elem_n, callback) {
 		if (callback->func != func)
 			continue;
 		if (callback->block_id > 0)