From: Josef Gajdusek <atx@atx.name>
Date: Sun, 11 May 2014 12:40:44 +0000 (+0200)
Subject: hwmon: (emc1403) fix inverted store_hyst()
X-Git-Tag: v4.9.8~6401^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=17c048fc4bd95efea208a1920f169547d8588f1f;p=platform%2Fkernel%2Flinux-rpi3.git

hwmon: (emc1403) fix inverted store_hyst()

Attempts to set the hysteresis value to a temperature below the target
limit fails with "write error: Numerical result out of range" due to
an inverted comparison.

Signed-off-by: Josef Gajdusek <atx@atx.name>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org
[Guenter Roeck: Updated headline and description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---

diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
index 90ec117..61d89d6 100644
--- a/drivers/hwmon/emc1403.c
+++ b/drivers/hwmon/emc1403.c
@@ -163,7 +163,7 @@ static ssize_t store_hyst(struct device *dev,
 	if (retval < 0)
 		goto fail;
 
-	hyst = val - retval * 1000;
+	hyst = retval * 1000 - val;
 	hyst = DIV_ROUND_CLOSEST(hyst, 1000);
 	if (hyst < 0 || hyst > 255) {
 		retval = -ERANGE;