From: Pawel Wasowski
Date: Wed, 10 Feb 2021 09:18:19 +0000 (+0100)
Subject: [Notification] Fix SVACE issue
X-Git-Tag: submit/tizen/20210217.032056~10
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=17a50d0a442dac15993cddf846966f98296c51d5;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git
[Notification] Fix SVACE issue
This commit fixes SVACE issue with WGID: 449860
[Verification] tct-notification-tizen-tests (auto): 100% pass rate
(The CommonNotification::SetAppControlInfoFrmJson function that was
changed, was called several times during tests)
Change-Id: If1caa5d141edb6c776a49ee9c2bfa5abc575efab
---
diff --git a/src/notification/common_notification.cc b/src/notification/common_notification.cc
index 1f824937..dbf904db 100644
--- a/src/notification/common_notification.cc
+++ b/src/notification/common_notification.cc
@@ -511,6 +511,12 @@ PlatformResult CommonNotification::SetApplicationControl(app_control_h app_handl
const std::string key = FromJson(obj, "key");
const picojson::array values = FromJson(obj, "value");
const char** arrayValue = (const char**)calloc(sizeof(char*), values.size());
+
+ if (!arrayValue) {
+ return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Set application control error",
+ ("Memory allocation failed"));
+ }
+
SCOPE_EXIT {
free(arrayValue);
};