From: Thomas Gleixner Date: Wed, 4 May 2011 06:18:34 +0000 (+0200) Subject: alarmtimer: Drop device refcount after rtc_open() X-Git-Tag: upstream/snapshot3+hdmi~10349^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=179eb03268aa1da03d90f1566ea85dc1478d3ae3;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git alarmtimer: Drop device refcount after rtc_open() class_find_device() takes a refcount on the rtc device. rtc_open() takes another one, so we can drop it after the rtc_open() call. Signed-off-by: Thomas Gleixner Cc: John Stultz --- diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c index e5db9b0..c6027fe 100644 --- a/kernel/time/alarmtimer.c +++ b/kernel/time/alarmtimer.c @@ -675,8 +675,14 @@ static int __init alarmtimer_init_late(void) /* Find an rtc device and init the rtc_timer */ dev = class_find_device(rtc_class, NULL, &str, has_wakealarm); /* If we have a device then str is valid. See has_wakealarm() */ - if (dev) + if (dev) { rtcdev = rtc_class_open(str); + /* + * Drop the reference we got in class_find_device, + * rtc_open takes its own. + */ + put_device(dev); + } if (!rtcdev) { printk(KERN_WARNING "No RTC device found, ALARM timers will" " not wake from suspend");