From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 5 Jun 2020 11:04:13 +0000 (+0300)
Subject: ethtool: linkinfo: remove an unnecessary NULL check
X-Git-Tag: v5.15~3655^2~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=178f67b1288b6952117fdc4e5ffbd4c4bd4e4a7f;p=platform%2Fkernel%2Flinux-starfive.git

ethtool: linkinfo: remove an unnecessary NULL check

This code generates a Smatch warning:

    net/ethtool/linkinfo.c:143 ethnl_set_linkinfo()
    warn: variable dereferenced before check 'info' (see line 119)

Fortunately, the "info" pointer is never NULL so the check can be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ethtool/linkinfo.c b/net/ethtool/linkinfo.c
index 677068d..5eaf173 100644
--- a/net/ethtool/linkinfo.c
+++ b/net/ethtool/linkinfo.c
@@ -140,8 +140,7 @@ int ethnl_set_linkinfo(struct sk_buff *skb, struct genl_info *info)
 
 	ret = __ethtool_get_link_ksettings(dev, &ksettings);
 	if (ret < 0) {
-		if (info)
-			GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
+		GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
 		goto out_ops;
 	}
 	lsettings = &ksettings.base;