From: Sherry Sun <sherry.sun@nxp.com>
Date: Thu, 23 Mar 2023 11:09:23 +0000 (+0800)
Subject: tty: serial: fsl_lpuart: fix crash in lpuart_uport_is_active
X-Git-Tag: v6.6.17~5173^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=178e00f36f934a88682d96aa046c1f90cb6f83a7;p=platform%2Fkernel%2Flinux-rpi.git

tty: serial: fsl_lpuart: fix crash in lpuart_uport_is_active

For serdev framework, tty->dev is a NULL pointer, lpuart_uport_is_active
calling device_may_wakeup() may cause kernel NULL pointer crash, so here
add the NULL pointer check before using it.

Fixes: 4f5cb8c5e915 ("tty: serial: fsl_lpuart: enable wakeup source for lpuart")
Cc: stable <stable@kernel.org>
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Link: https://lore.kernel.org/r/20230323110923.24581-1-sherry.sun@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index edc6e35..074bfed 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2948,7 +2948,7 @@ static bool lpuart_uport_is_active(struct lpuart_port *sport)
 	tty = tty_port_tty_get(port);
 	if (tty) {
 		tty_dev = tty->dev;
-		may_wake = device_may_wakeup(tty_dev);
+		may_wake = tty_dev && device_may_wakeup(tty_dev);
 		tty_kref_put(tty);
 	}