From: Nicholas Clark <nick@ccl4.org>
Date: Tue, 9 Aug 2011 08:51:09 +0000 (+0200)
Subject: In checkcfgvar.pl, inline check_cfg() into its only caller.
X-Git-Tag: accepted/trunk/20130322.191538~3148^2~60^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1750d3ff2eed6c4b057e139a98d99b148b9fc4c6;p=platform%2Fupstream%2Fperl.git

In checkcfgvar.pl, inline check_cfg() into its only caller.
---

diff --git a/Porting/checkcfgvar.pl b/Porting/checkcfgvar.pl
index 61ecb1e..b7022dc 100755
--- a/Porting/checkcfgvar.pl
+++ b/Porting/checkcfgvar.pl
@@ -87,19 +87,6 @@ read_file("MANIFEST",
 
 my @MASTER_CFG = sort keys %MASTER_CFG;
 
-sub check_cfg {
-    my ($fn, $cfg) = @_;
-    for my $v (@MASTER_CFG) {
-	exists $cfg->{$v} and next;
-	if ($opt_l) {
-	    $lst{$fn}{$v}++;
-	}
-	else {
-	    print "$fn: missing '$v'\n";
-	}
-    }
-}
-
 for my $cfg (@CFG) {
     unless (exists $MANIFEST{$cfg}) {
 	print STDERR "[skipping not-expected '$cfg']\n";
@@ -130,7 +117,16 @@ for my $cfg (@CFG) {
     if ($cfg eq 'configure.com') {
 	$cfg{startperl}++; # Cheat.
     }
-    check_cfg($cfg, \%cfg);
+
+    for my $v (@MASTER_CFG) {
+	exists $cfg{$v} and next;
+	if ($opt_l) {
+	    $lst{$cfg}{$v}++;
+	}
+	else {
+	    print "$cfg: missing '$v'\n";
+	}
+    }
 }
 
 $opt_l and print "$_\n" for sort keys %lst;