From: Jason Ekstrand Date: Mon, 24 Oct 2016 21:27:32 +0000 (-0700) Subject: i965/blit: Remove a bogus assertion X-Git-Tag: upstream/17.1.0~5143 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=174f4900b294f939c85cfa94f5d8401ce73e5522;p=platform%2Fupstream%2Fmesa.git i965/blit: Remove a bogus assertion This assertion, while valid for linear buffers, doesn't work properly for tiled memory. It used to work most of the time because the offset provided was always to the left-hand edge of the image. However, if you use a byte offset to get to the inside of the image, the height * stride calculation may actually end up being too large. Signed-off-by: Jason Ekstrand Reviewed-by: Topi Pohjolainen Reviewed-by: Anuj Phogat --- diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c index b7a9cc9..bc97e66 100644 --- a/src/mesa/drivers/dri/i965/intel_blit.c +++ b/src/mesa/drivers/dri/i965/intel_blit.c @@ -585,10 +585,6 @@ intelEmitCopyBlit(struct brw_context *brw, assert(dst_x < dst_x2); assert(dst_y < dst_y2); - assert(src_offset + (src_y + h - 1) * abs(src_pitch) + - (w * cpp) <= src_buffer->size); - assert(dst_offset + (dst_y + h - 1) * abs(dst_pitch) + - (w * cpp) <= dst_buffer->size); BEGIN_BATCH_BLT_TILED(length, dst_y_tiled, src_y_tiled); OUT_BATCH(CMD | (length - 2));