From: Dmitry Torokhov Date: Mon, 4 Nov 2019 23:27:41 +0000 (-0800) Subject: Input: ili210x - do not unconditionally mark touchscreen as wakeup source X-Git-Tag: v5.10.7~1015^2~89^2~8^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=172bb5f34c0dd5e94eb877edb3e8721d1ebd5c75;p=platform%2Fkernel%2Flinux-rpi.git Input: ili210x - do not unconditionally mark touchscreen as wakeup source I2C devices that are supposed to be wakeup sources should be instantiated with I2C_CLIENT_WAKE flag (which can be either set by in board info, or retrieved from "wakeup-source" property); individual drivers should not be marking devices as wakeup sources unconditionally. Tested-by: Adam Ford #imx6q-logicpd Tested-by: Sven Van Asbroeck # ILI2118A variant Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c index 22811df..ef0da2f 100644 --- a/drivers/input/touchscreen/ili210x.c +++ b/drivers/input/touchscreen/ili210x.c @@ -439,8 +439,6 @@ static int ili210x_i2c_probe(struct i2c_client *client, return error; } - device_init_wakeup(dev, 1); - dev_dbg(dev, "ILI210x initialized (IRQ: %d), firmware version %d.%d.%d", client->irq, firmware.id, firmware.major, firmware.minor);