From: Markus Elfring Date: Sat, 16 Jul 2016 09:28:36 +0000 (+0200) Subject: drm/amdgpu: Delete an unnecessary check before drm_gem_object_unreference_unlocked() X-Git-Tag: v4.14-rc1~2738^2~2^2~40 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1721c69c3300f39ea63c7b551764873bb7ac83d1;p=platform%2Fkernel%2Flinux-rpi.git drm/amdgpu: Delete an unnecessary check before drm_gem_object_unreference_unlocked() The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Reviewed-by: Christian König Signed-off-by: Markus Elfring Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index dd965f2..76f9602 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -516,9 +516,7 @@ static void amdgpu_user_framebuffer_destroy(struct drm_framebuffer *fb) { struct amdgpu_framebuffer *amdgpu_fb = to_amdgpu_framebuffer(fb); - if (amdgpu_fb->obj) { - drm_gem_object_unreference_unlocked(amdgpu_fb->obj); - } + drm_gem_object_unreference_unlocked(amdgpu_fb->obj); drm_framebuffer_cleanup(fb); kfree(amdgpu_fb); }