From: Dave Stevenson Date: Wed, 13 Feb 2019 12:51:03 +0000 (+0000) Subject: staging: mmal-vchiq: If the VPU returns an error, don't negate it X-Git-Tag: accepted/tizen/unified/20200709.164653~1103 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=170ce79f32d864ea00a26ab07376bcb155e354c1;p=platform%2Fkernel%2Flinux-rpi.git staging: mmal-vchiq: If the VPU returns an error, don't negate it There is an enum for the errors that the VPU can return. port_parameter_get was negating that value, but also using -EINVAL from the Linux error codes. Pass the VPU error code as positive values. Should the function need to pass a Linux failure, then return that as negative. Signed-off-by: Dave Stevenson --- diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index 59a4d24..cfc861d 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -1400,7 +1400,8 @@ static int port_parameter_get(struct vchiq_mmal_instance *instance, goto release_msg; } - ret = -rmsg->u.port_parameter_get_reply.status; + ret = rmsg->u.port_parameter_get_reply.status; + /* port_parameter_get_reply.size includes the header, * whilst *value_size doesn't. */