From: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date: Wed, 13 Apr 2011 14:09:04 +0000 (+0200)
Subject: flacenc: Don't store image tags inside the vorbiscomments and the flac metadata
X-Git-Tag: RELEASE-0.10.29~80
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=16f82e46f5c0120b31679435c26988edf9ede3da;p=platform%2Fupstream%2Fgst-plugins-good.git

flacenc: Don't store image tags inside the vorbiscomments and the flac metadata

Instead only store them inside the flac metadata. There's
no point in storing them twice and the flac metadata is
still the official way to store image tags inside flac.
---

diff --git a/ext/flac/gstflacenc.c b/ext/flac/gstflacenc.c
index a3de54333..b59d7c266 100644
--- a/ext/flac/gstflacenc.c
+++ b/ext/flac/gstflacenc.c
@@ -453,6 +453,12 @@ add_one_tag (const GstTagList * list, const gchar * tag, gpointer user_data)
   GList *it;
   GstFlacEnc *flacenc = GST_FLAC_ENC (user_data);
 
+  /* IMAGE and PREVIEW_IMAGE tags are already written
+   * differently, no need to store them inside the
+   * vorbiscomments too */
+  if (strcmp (tag, GST_TAG_IMAGE) == 0 || strcmp (tag, GST_TAG_PREVIEW_IMAGE))
+    return;
+
   comments = gst_tag_to_vorbis_comments (list, tag);
   for (it = comments; it != NULL; it = it->next) {
     FLAC__StreamMetadata_VorbisComment_Entry commment_entry;