From: Sebastian Dröge <sebastian@centricular.com>
Date: Mon, 4 Dec 2017 16:08:39 +0000 (+0200)
Subject: gst: gst_element_remove_pad() is transfer none for the pad
X-Git-Tag: 1.16.2~567
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=16de48ae03651cd614c065175354e4f48f2947b1;p=platform%2Fupstream%2Fgstreamer.git

gst: gst_element_remove_pad() is transfer none for the pad

While the refcount of the pad is decreased, it's the refcount that is
owned by the parent (i.e. the element) and not the one passed in by the
caller.

Fixes a memory leak in bindings.
---

diff --git a/gst/gstelement.c b/gst/gstelement.c
index 97f327d..132dab1 100644
--- a/gst/gstelement.c
+++ b/gst/gstelement.c
@@ -751,7 +751,7 @@ no_direction:
 /**
  * gst_element_remove_pad:
  * @element: a #GstElement to remove pad from.
- * @pad: (transfer full): the #GstPad to remove from the element.
+ * @pad: (transfer none): the #GstPad to remove from the element.
  *
  * Removes @pad from @element. @pad will be destroyed if it has not been
  * referenced elsewhere using gst_object_unparent().