From: chakradhar Date: Tue, 17 Mar 2020 08:38:39 +0000 (+0530) Subject: coverity issues X-Git-Tag: submit/tizen/20200317.115120^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1684a9a63dfad298614de8d46bd03e2967c5ba9c;p=platform%2Fcore%2Fapi%2Fmaps-service.git coverity issues Change-Id: Ia108969416265fa6394eed69d03fd4c3cdf0490c --- diff --git a/src/api/maps_condition.cpp b/src/api/maps_condition.cpp index a33b83f..6c74228 100644 --- a/src/api/maps_condition.cpp +++ b/src/api/maps_condition.cpp @@ -86,7 +86,10 @@ bool maps_condition_check_maps_feature(void) static bool is_read = false; if (!is_read) { - system_info_get_platform_bool(MAPS_FEATURE, &is_supported); + int ret = system_info_get_platform_bool(MAPS_FEATURE, &is_supported); + if(ret != SYSTEM_INFO_ERROR_NONE) + MAPS_LOGE("failed to call system_info_get_platform_bool(), error code: %d",ret); + MAPS_LOGD("maps feature is%ssupported", (is_supported ? " " : " not ")); is_read = true; } @@ -99,7 +102,10 @@ bool maps_condition_check_internet_feature(void) static bool is_read = false; if (!is_read) { - system_info_get_platform_bool(INTERNET_FEATURE, &is_supported); + int ret = system_info_get_platform_bool(INTERNET_FEATURE, &is_supported); + if(ret != SYSTEM_INFO_ERROR_NONE) + MAPS_LOGE("failed to call system_info_get_platform_bool(), error code: %d",ret); + MAPS_LOGD("internet feature is%ssupported", (is_supported ? " " : " not ")); is_read = true; } diff --git a/src/maps_util.cpp b/src/maps_util.cpp index e2a75e2..f64acf7 100644 --- a/src/maps_util.cpp +++ b/src/maps_util.cpp @@ -46,8 +46,12 @@ int maps_get_screen_dpi(int *dpi) return MAPS_ERROR_INVALID_PARAMETER; static int __dpi = DEFAULT_UNKNOWN_DPI; - if (__dpi == DEFAULT_UNKNOWN_DPI) - system_info_get_platform_int("http://tizen.org/feature/screen.dpi", &__dpi); + if (__dpi == DEFAULT_UNKNOWN_DPI){ + int ret = system_info_get_platform_int("http://tizen.org/feature/screen.dpi", &__dpi); + if(ret != SYSTEM_INFO_ERROR_NONE) + MAPS_LOGE("failed to call system_info_get_platform_int(), error code: %d",ret); + } + *dpi = __dpi; return MAPS_ERROR_NONE; }