From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 7 Sep 2023 09:54:50 +0000 (+0300)
Subject: mmc: sdhci-sprd: Fix error code in sdhci_sprd_tuning()
X-Git-Tag: v6.6.7~1702^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=168054ca5cf783e07518681fad0904de8dcc6b17;hp=1202d617e3d04c8d27a14ef30784a698c48170b3;p=platform%2Fkernel%2Flinux-starfive.git

mmc: sdhci-sprd: Fix error code in sdhci_sprd_tuning()

Return an error code if sdhci_sprd_get_best_clk_sample() fails.
Currently, it returns success.

Fixes: d83d251bf3c2 ("mmc: sdhci-sprd: Add SD HS mode online tuning")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Wenchao Chen <wenchao.chen@unisoc.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/a8af0a08-8405-43cc-bd83-85ff25f572ca@moroto.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---

diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
index 649ae07..6b84ba2 100644
--- a/drivers/mmc/host/sdhci-sprd.c
+++ b/drivers/mmc/host/sdhci-sprd.c
@@ -644,6 +644,7 @@ static int sdhci_sprd_tuning(struct mmc_host *mmc, struct mmc_card *card,
 	best_clk_sample = sdhci_sprd_get_best_clk_sample(mmc, value);
 	if (best_clk_sample < 0) {
 		dev_err(mmc_dev(host->mmc), "all tuning phase fail!\n");
+		err = best_clk_sample;
 		goto out;
 	}