From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Wed, 22 Aug 2012 10:19:01 +0000 (+0530)
Subject: usb: gadget: s3c2410_udc: Move assignment outside if condition
X-Git-Tag: upstream/snapshot3+hdmi~6591^2~141^2~43
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1660c8944652aac142e622d276c3750f735a568f;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

usb: gadget: s3c2410_udc: Move assignment outside if condition

Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---

diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index d9e3a21..e895ea1 100644
--- a/drivers/usb/gadget/s3c2410_udc.c
+++ b/drivers/usb/gadget/s3c2410_udc.c
@@ -1696,7 +1696,8 @@ static int s3c2410_udc_start(struct usb_gadget_driver *driver,
 	udc->gadget.dev.driver = &driver->driver;
 
 	/* Bind the driver */
-	if ((retval = device_add(&udc->gadget.dev)) != 0) {
+	retval = device_add(&udc->gadget.dev);
+	if (retval) {
 		dev_err(&udc->gadget.dev, "Error in device_add() : %d\n", retval);
 		goto register_error;
 	}
@@ -1704,7 +1705,8 @@ static int s3c2410_udc_start(struct usb_gadget_driver *driver,
 	dprintk(DEBUG_NORMAL, "binding gadget driver '%s'\n",
 		driver->driver.name);
 
-	if ((retval = bind(&udc->gadget)) != 0) {
+	retval = bind(&udc->gadget);
+	if (retval) {
 		device_del(&udc->gadget.dev);
 		goto register_error;
 	}