From: Steve French <stfrench@microsoft.com>
Date: Thu, 24 Jun 2021 00:32:24 +0000 (-0500)
Subject: cifs: missing null pointer check in cifs_mount
X-Git-Tag: v5.15~861^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=162004a2f7ef5c77600e364dc4e9315b0e6ca386;p=platform%2Fkernel%2Flinux-starfive.git

cifs: missing null pointer check in cifs_mount

We weren't checking if tcon is null before setting dfs path,
although we check for null tcon in an earlier assignment statement.

Addresses-Coverity: 1476411 ("Dereference after null check")
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 8d95607..c807937 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3451,7 +3451,7 @@ int cifs_mount(struct cifs_sb_info *cifs_sb, struct smb3_fs_context *ctx)
 			rc = -ELOOP;
 	} while (rc == -EREMOTE);
 
-	if (rc)
+	if (rc || !tcon)
 		goto error;
 
 	kfree(ref_path);