From: David S. Miller Date: Thu, 28 Jun 2012 04:28:14 +0000 (-0700) Subject: phy: Fix warning in get_phy_device(). X-Git-Tag: v3.6-rc1~125^2~361 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=160c85f0e050d92c0e42321aab2ffc343594e1c0;p=platform%2Fkernel%2Flinux-3.10.git phy: Fix warning in get_phy_device(). drivers/net/phy/phy_device.c: In function ‘get_phy_device’: drivers/net/phy/phy_device.c:340:14: warning: ‘phy_id’ may be used uninitialized in this function [-Wmaybe-uninitialized] GCC can't see that when we return zero we always initialize phy_id and that's the only path where we use it. Initialize phy_id to zero to shut it up. Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index ef4cdee..47e02e7 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -327,9 +327,9 @@ static int get_phy_id(struct mii_bus *bus, int addr, u32 *phy_id, */ struct phy_device *get_phy_device(struct mii_bus *bus, int addr, bool is_c45) { - struct phy_device *dev = NULL; - u32 phy_id; struct phy_c45_device_ids c45_ids = {0}; + struct phy_device *dev = NULL; + u32 phy_id = 0; int r; r = get_phy_id(bus, addr, &phy_id, is_c45, &c45_ids);