From: Laurent Pinchart Date: Fri, 13 Jan 2023 09:54:16 +0000 (+0100) Subject: media: imx-pxp: Don't set bus_info manually in .querycap() X-Git-Tag: v6.6.7~3400^2~2^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=15acb0824eca2871ea58d09db664422512677966;p=platform%2Fkernel%2Flinux-starfive.git media: imx-pxp: Don't set bus_info manually in .querycap() The v4l2_capability.bus_info field is set by the V4L2 core when left empty by the .querycap() handler. This is the recommended practice, in order to ensure bus_info coherence between drivers. Don't set it manually. Signed-off-by: Laurent Pinchart Signed-off-by: Michael Tretter Reviewed-by: Philipp Zabel Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c index 964570e..8881400 100644 --- a/drivers/media/platform/nxp/imx-pxp.c +++ b/drivers/media/platform/nxp/imx-pxp.c @@ -1107,8 +1107,6 @@ static int pxp_querycap(struct file *file, void *priv, { strscpy(cap->driver, MEM2MEM_NAME, sizeof(cap->driver)); strscpy(cap->card, MEM2MEM_NAME, sizeof(cap->card)); - snprintf(cap->bus_info, sizeof(cap->bus_info), - "platform:%s", MEM2MEM_NAME); return 0; }