From: Robert P. J. Day Date: Tue, 12 May 2009 20:43:36 +0000 (-0700) Subject: scripts/headers_check.pl: correct RE in header CONFIG leak check X-Git-Tag: upstream/snapshot3+hdmi~18613^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1581c1cede3b180b77aa08024c6ca406252cc21f;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git scripts/headers_check.pl: correct RE in header CONFIG leak check Correct the regular expression in scripts/headers_check.pl to include '_' as a valid character in the class; otherwise, the check will report a "leaked" symbol of CONFIG_A_B_C as merely CONFIG_A. This patch will make no difference whatsoever in the current kernel tree as the call to the perl routine that does that check is currently commented out: &check_include(); &check_asm_types(); &check_sizetypes(); &check_prototypes(); # Dropped for now. Too much noise &check_config(); However, I noticed that problem when I was building the yum downloadable kernel source rpm for fedora 11 (beta), which *does* run that check, and that's where the problem became obvious. Signed-off-by: Robert P. J. Day Cc: David Woodhouse Signed-off-by: Andrew Morton Signed-off-by: Sam Ravnborg --- diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 56f90a4..4414c43 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -70,7 +70,7 @@ sub check_prototypes sub check_config { - if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9]+)[^a-zA-Z0-9]/) { + if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9_]+)[^a-zA-Z0-9_]/) { printf STDERR "$filename:$lineno: leaks CONFIG_$1 to userspace where it is not valid\n"; } }