From: Hao Ge Date: Sun, 8 Oct 2023 03:29:08 +0000 (+0800) Subject: firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels() X-Git-Tag: v6.6.17~3691^2~7^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1558b1a8dd388f5fcc3abc1e24de854a295044c3;p=platform%2Fkernel%2Flinux-rpi.git firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels() dsp_chan->name and chan_name points to same block of memory, because dev_err still needs to be used it,so we need free it's memory after use to avoid use_after_free. Fixes: e527adfb9b7d ("firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels()") Signed-off-by: Hao Ge Reviewed-by: Daniel Baluta Signed-off-by: Shawn Guo --- diff --git a/drivers/firmware/imx/imx-dsp.c b/drivers/firmware/imx/imx-dsp.c index 508eab3..a48a58e 100644 --- a/drivers/firmware/imx/imx-dsp.c +++ b/drivers/firmware/imx/imx-dsp.c @@ -114,11 +114,11 @@ static int imx_dsp_setup_channels(struct imx_dsp_ipc *dsp_ipc) dsp_chan->idx = i % 2; dsp_chan->ch = mbox_request_channel_byname(cl, chan_name); if (IS_ERR(dsp_chan->ch)) { - kfree(dsp_chan->name); ret = PTR_ERR(dsp_chan->ch); if (ret != -EPROBE_DEFER) dev_err(dev, "Failed to request mbox chan %s ret %d\n", chan_name, ret); + kfree(dsp_chan->name); goto out; }