From: Carsten Haitzler (Rasterman) Date: Wed, 1 Apr 2015 11:43:54 +0000 (+0900) Subject: efreetd - cache - fix handling a text index file with 0 length lines X-Git-Tag: v1.14.0-alpha1~63 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=155126828010e8a1914050958866130422437cee;p=platform%2Fupstream%2Fefl.git efreetd - cache - fix handling a text index file with 0 length lines this fixes an efreetd cache crash where files like icon.exts might have lines with just a newline and no extension/content on the line. @fix --- diff --git a/src/bin/efreet/efreetd_cache.c b/src/bin/efreet/efreetd_cache.c index 0d58897..6c43749 100644 --- a/src/bin/efreet/efreetd_cache.c +++ b/src/bin/efreet/efreetd_cache.c @@ -411,9 +411,11 @@ fill_list(const char *file, Eina_List **l) if (!it) goto error; EINA_ITERATOR_FOREACH(it, line) { - const char *end; - end = line->end - 1; - *l = eina_list_append(*l, eina_stringshare_add_length(line->start, end - line->start)); + if (line->end > line->start) + { + const char *end = line->end - 1; + *l = eina_list_append(*l, eina_stringshare_add_length(line->start, end - line->start)); + } } eina_iterator_free(it); error: