From: Anson Huang Date: Mon, 30 Jul 2018 16:56:49 +0000 (+0800) Subject: thermal: of-thermal: disable passive polling when thermal zone is disabled X-Git-Tag: v4.19~267^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=152395fd03d4ce1e535a75cdbf58105e50587611;p=platform%2Fkernel%2Flinux-rpi.git thermal: of-thermal: disable passive polling when thermal zone is disabled When thermal zone is in passive mode, disabling its mode from sysfs is NOT taking effect at all, it is still polling the temperature of the disabled thermal zone and handling all thermal trips, it makes user confused. The disabling operation should disable the thermal zone behavior completely, for both active and passive mode, this patch clears the passive_delay when thermal zone is disabled and restores it when it is enabled. Signed-off-by: Anson Huang Signed-off-by: Eduardo Valentin --- diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c index 977a830..4f28165 100644 --- a/drivers/thermal/of-thermal.c +++ b/drivers/thermal/of-thermal.c @@ -260,10 +260,13 @@ static int of_thermal_set_mode(struct thermal_zone_device *tz, mutex_lock(&tz->lock); - if (mode == THERMAL_DEVICE_ENABLED) + if (mode == THERMAL_DEVICE_ENABLED) { tz->polling_delay = data->polling_delay; - else + tz->passive_delay = data->passive_delay; + } else { tz->polling_delay = 0; + tz->passive_delay = 0; + } mutex_unlock(&tz->lock);