From: Tang Yuantian Date: Wed, 6 May 2015 03:21:33 +0000 (+0800) Subject: fsl/sata: Replace sprintf() with snprintf() X-Git-Tag: v2015.07-rc2~55 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=14f66d65a33f622b8138ab0fcd1e18060a2355c2;p=platform%2Fkernel%2Fu-boot.git fsl/sata: Replace sprintf() with snprintf() Function 'sprintf' does not check buffer boundaries but outputs to the buffer of fixed size which could potentially cause buffer overflow. Use a safer function to replace it. Signed-off-by: Tang Yuantian --- diff --git a/drivers/block/fsl_sata.c b/drivers/block/fsl_sata.c index 71d7cec..735708a 100644 --- a/drivers/block/fsl_sata.c +++ b/drivers/block/fsl_sata.c @@ -113,7 +113,7 @@ int init_sata(int dev) /* Save the private struct to block device struct */ sata_dev_desc[dev].priv = (void *)sata; - sprintf(sata->name, "SATA%d", dev); + snprintf(sata->name, 12, "SATA%d", dev); /* Set the controller register base address to device struct */ reg = (fsl_sata_reg_t *)(fsl_sata_info[dev].sata_reg_base);