From: wentalou Date: Tue, 18 Dec 2018 07:42:08 +0000 (+0800) Subject: drm/amdgpu: psp_ring_destroy cause psp->km_ring.ring_mem NULL X-Git-Tag: v5.15~6763^2~26^2~166 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=14d20ec7f31ef96a2e7dcf7880b13dde1d473b56;p=platform%2Fkernel%2Flinux-starfive.git drm/amdgpu: psp_ring_destroy cause psp->km_ring.ring_mem NULL psp_ring_destroy inside psp_load_fw cause psp->km_ring.ring_mem NULL. Call Trace occurred when psp_cmd_submit. should be psp_ring_stop instead. Reviewed-by: Xiangliang Yu Signed-off-by: Wentao Lou Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index 7f5ce37..8189a90 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c @@ -547,7 +547,7 @@ static int psp_load_fw(struct amdgpu_device *adev) struct psp_context *psp = &adev->psp; if (amdgpu_sriov_vf(adev) && adev->in_gpu_reset) { - psp_ring_destroy(psp, PSP_RING_TYPE__KM); + psp_ring_stop(psp, PSP_RING_TYPE__KM); /* should not destroy ring, only stop */ goto skip_memalloc; }