From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 1 Aug 2017 11:02:01 +0000 (+0300)
Subject: tracing: Missing error code in tracer_alloc_buffers()
X-Git-Tag: v4.14-rc1~246^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=147d88e0b5eb90191bc5c12ca0a3c410b75a13d2;p=platform%2Fkernel%2Flinux-rpi.git

tracing: Missing error code in tracer_alloc_buffers()

If ring_buffer_alloc() or one of the next couple function calls fail
then we should return -ENOMEM but the current code returns success.

Link: http://lkml.kernel.org/r/20170801110201.ajdkct7vwzixahvx@mwanda

Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: stable@vger.kernel.org
Fixes: b32614c03413 ('tracing/rb: Convert to hotplug state machine')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 784fb43b2abe..d815fc317e9d 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -8293,6 +8293,7 @@ __init static int tracer_alloc_buffers(void)
 	if (ret < 0)
 		goto out_free_cpumask;
 	/* Used for event triggers */
+	ret = -ENOMEM;
 	temp_buffer = ring_buffer_alloc(PAGE_SIZE, RB_FL_OVERWRITE);
 	if (!temp_buffer)
 		goto out_rm_hp_state;