From: Al Viro <viro@zeniv.linux.org.uk>
Date: Sat, 15 Jun 2013 06:26:35 +0000 (+0400)
Subject: proc_fill_cache(): kill pointless check
X-Git-Tag: upstream/snapshot3+hdmi~4813^2~49
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=147ce69974cc1b44defa2d3d9c202ee83e2f2f3b;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

proc_fill_cache(): kill pointless check

we'd just checked that child->d_inode is non-NULL, for fuck sake!

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 0016350..306419c 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1710,10 +1710,8 @@ bool proc_fill_cache(struct file *file, struct dir_context *ctx,
 	if (!child || IS_ERR(child) || !child->d_inode)
 		goto end_instantiate;
 	inode = child->d_inode;
-	if (inode) {
-		ino = inode->i_ino;
-		type = inode->i_mode >> 12;
-	}
+	ino = inode->i_ino;
+	type = inode->i_mode >> 12;
 	dput(child);
 end_instantiate:
 	if (!ino)