From: Dan Carpenter Date: Wed, 23 Sep 2015 09:42:28 +0000 (+0300) Subject: ALSA: core: check for underflow in snd_pcm_sw_params() X-Git-Tag: v5.15~14585^2~31^2~102 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=145d92e77e6f34f53773fdb06789816ec2b6c7b3;p=platform%2Fkernel%2Flinux-starfive.git ALSA: core: check for underflow in snd_pcm_sw_params() As far as I can see, having an invalid ->tstamp_mode is harmless, but adding a check silences a static checker warning. Signed-off-by: Dan Carpenter Signed-off-by: Takashi Iwai --- diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 75888dd..4863af5 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -650,7 +650,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream, } snd_pcm_stream_unlock_irq(substream); - if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST) + if (params->tstamp_mode < 0 || + params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST) return -EINVAL; if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12) && params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST)