From: Takashi Iwai Date: Thu, 4 Mar 2021 08:50:09 +0000 (+0100) Subject: ALSA: usb-audio: Apply the control quirk to Plantronics headsets X-Git-Tag: v5.10.25~125 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=144ebd02a11884df8b9f5ab1737eef9a6d8db128;p=platform%2Fkernel%2Flinux-rpi.git ALSA: usb-audio: Apply the control quirk to Plantronics headsets commit 06abcb18b3a021ba1a3f2020cbefb3ed04e59e72 upstream. Other Plantronics headset models seem requiring the same workaround as C320-M to add the 20ms delay for the control messages, too. Apply the workaround generically for devices with the vendor ID 0x047f. Note that the problem didn't surface before 5.11 just with luck. Since 5.11 got a big code rewrite about the stream handling, the parameter setup procedure has changed, and this seemed triggering the problem more often. BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1182552 Cc: Link: https://lore.kernel.org/r/20210304085009.4770-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 01c2f61..a995bf5 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1674,10 +1674,10 @@ void snd_usb_ctl_msg_quirk(struct usb_device *dev, unsigned int pipe, msleep(20); /* - * Plantronics C320-M needs a delay to avoid random - * microhpone failures. + * Plantronics headsets (C320, C320-M, etc) need a delay to avoid + * random microhpone failures. */ - if (chip->usb_id == USB_ID(0x047f, 0xc025) && + if (USB_ID_VENDOR(chip->usb_id) == 0x047f && (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS) msleep(20);