From: Colin Ian King Date: Sun, 24 Apr 2022 18:22:27 +0000 (+0100) Subject: clk: mux: remove redundant initialization of variable width X-Git-Tag: v6.1-rc5~1232^2~3^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=14364fca21208d0954d594e1eccb4ad239881081;p=platform%2Fkernel%2Flinux-starfive.git clk: mux: remove redundant initialization of variable width Variable width is being ininitialized with a value that is never read. The ininitializtion is redundant and can be removed. Move the variable to the scope it is required. Cleans up cppcheck warning: Variable 'width' is assigned a value that is never used. Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20220424182227.1364966-1-colin.i.king@gmail.com Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c index 214045f..fa817c3 100644 --- a/drivers/clk/clk-mux.c +++ b/drivers/clk/clk-mux.c @@ -157,11 +157,11 @@ struct clk_hw *__clk_hw_register_mux(struct device *dev, struct device_node *np, struct clk_mux *mux; struct clk_hw *hw; struct clk_init_data init = {}; - u8 width = 0; int ret = -EINVAL; if (clk_mux_flags & CLK_MUX_HIWORD_MASK) { - width = fls(mask) - ffs(mask) + 1; + u8 width = fls(mask) - ffs(mask) + 1; + if (width + shift > 16) { pr_err("mux value exceeds LOWORD field\n"); return ERR_PTR(-EINVAL);