From: Dan Carpenter Date: Wed, 11 Jun 2014 08:15:13 +0000 (+0300) Subject: pinctrl: berlin: fix an error code in berlin_pinctrl_probe() X-Git-Tag: v4.14-rc1~7272^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1419d8151be990f115c38deac497ad84d26434dd;p=platform%2Fkernel%2Flinux-rpi.git pinctrl: berlin: fix an error code in berlin_pinctrl_probe() We are returning success here because PTR_ERR(NULL) is zero. We should be returning -ENODEV. Fixes: 3de68d331c24 ('pinctrl: berlin: add the core pinctrl driver for Marvell Berlin SoCs') Signed-off-by: Dan Carpenter Acked-by: Sebastian Hesselbarth Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c index edf5d2f..86db223 100644 --- a/drivers/pinctrl/berlin/berlin.c +++ b/drivers/pinctrl/berlin/berlin.c @@ -320,7 +320,7 @@ int berlin_pinctrl_probe(struct platform_device *pdev, regmap = dev_get_regmap(&pdev->dev, NULL); if (!regmap) - return PTR_ERR(regmap); + return -ENODEV; pctrl = devm_kzalloc(dev, sizeof(*pctrl), GFP_KERNEL); if (!pctrl)