From: mstarzinger@chromium.org Date: Wed, 10 Sep 2014 09:52:50 +0000 (+0000) Subject: Enable typed pipeline for TurboFan. X-Git-Tag: upstream/4.7.83~7017 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=13f01e65c43a3616cbc2ed5bcab0a8080fa1f488;p=platform%2Fupstream%2Fv8.git Enable typed pipeline for TurboFan. R=danno@chromium.org Review URL: https://codereview.chromium.org/552303003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23830 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/flag-definitions.h b/src/flag-definitions.h index fe5f443..8ca273e 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -330,7 +330,7 @@ DEFINE_BOOL(trace_turbo_types, true, "trace generated TurboFan types") DEFINE_BOOL(trace_turbo_scheduler, false, "trace generated TurboFan scheduler") DEFINE_BOOL(turbo_verify, false, "verify TurboFan graphs at each phase") DEFINE_BOOL(turbo_stats, false, "print TurboFan statistics") -DEFINE_BOOL(turbo_types, false, "use typed lowering in TurboFan") +DEFINE_BOOL(turbo_types, true, "use typed lowering in TurboFan") DEFINE_BOOL(turbo_source_positions, false, "track source code positions when building TurboFan IR") DEFINE_BOOL(context_specialization, false, diff --git a/test/benchmarks/testcfg.py b/test/benchmarks/testcfg.py index 6607bef..c8d05e6 100644 --- a/test/benchmarks/testcfg.py +++ b/test/benchmarks/testcfg.py @@ -186,7 +186,8 @@ class BenchmarksTestSuite(testsuite.TestSuite): # Both --nocrankshaft and --stressopt are very slow. Add TF but without # always opt to match the way the benchmarks are run for performance # testing. - return [[], ["--turbo-filter=*"]] + # TODO(mstarzinger): Enable typed pipeline soon! + return [[], ["--turbo-filter=*", "--noturbo-types"]] def GetSuite(name, root): diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 6ca32e4..21813a1 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -98,6 +98,36 @@ 'test-run-inlining/InlineTwiceDependentDiamond': [SKIP], 'test-run-inlining/InlineTwiceDependentDiamondDifferent': [SKIP], + # TODO(mstarzinger): Causes crash in generated code, needs investigation. + 'test-api/FixedUint8Array': [PASS, NO_VARIANTS], + 'test-api/FixedUint8ClampedArray': [PASS, NO_VARIANTS], + 'test-api/FixedInt8Array': [PASS, NO_VARIANTS], + 'test-api/FixedUint16Array': [PASS, NO_VARIANTS], + 'test-api/FixedInt16Array': [PASS, NO_VARIANTS], + 'test-api/FixedUint32Array': [PASS, NO_VARIANTS], + 'test-api/FixedInt32Array': [PASS, NO_VARIANTS], + 'test-api/FixedFloat32Array': [PASS, NO_VARIANTS], + 'test-api/FixedFloat64Array': [PASS, NO_VARIANTS], + 'test-api/ExternalInt8Array': [PASS, NO_VARIANTS], + 'test-api/ExternalUint8Array': [PASS, NO_VARIANTS], + 'test-api/ExternalUint8ClampedArray': [PASS, NO_VARIANTS], + 'test-api/ExternalInt16Array': [PASS, NO_VARIANTS], + 'test-api/ExternalUint32Array': [PASS, NO_VARIANTS], + 'test-api/ExternalUint16Array': [PASS, NO_VARIANTS], + 'test-api/ExternalInt32Array': [PASS, NO_VARIANTS], + 'test-api/ExternalFloat32Array': [PASS, NO_VARIANTS], + 'test-api/ExternalArrays': [PASS, NO_VARIANTS], + 'test-api/ExternalFloat64Array': [PASS, NO_VARIANTS], + 'test-api/Uint8Array': [PASS, NO_VARIANTS], + 'test-api/Int8Array': [PASS, NO_VARIANTS], + 'test-api/Uint16Array': [PASS, NO_VARIANTS], + 'test-api/Int16Array': [PASS, NO_VARIANTS], + 'test-api/Uint32Array': [PASS, NO_VARIANTS], + 'test-api/Int32Array': [PASS, NO_VARIANTS], + 'test-api/Float64Array': [PASS, NO_VARIANTS], + 'test-api/Float32Array': [PASS, NO_VARIANTS], + 'test-api/Uint8ClampedArray': [PASS, NO_VARIANTS], + # Some tests are just too slow to run for now. 'test-api/Threading*': [PASS, NO_VARIANTS], 'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [PASS, NO_VARIANTS], diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index a2a3a5a..2d763ff 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -67,9 +67,38 @@ 'debug-references': [PASS, NO_VARIANTS], 'regress/regress-263': [PASS, NO_VARIANTS], + # TODO(mstarzinger): Some runtime functions expect Smi but get HeapNumber. + 'array-functions-prototype-misc': [PASS, NO_VARIANTS], + 'array-join': [PASS, NO_VARIANTS], + 'sparse-array-reverse': [PASS, NO_VARIANTS], + + # TODO(mstarzinger): Causes crash in generated code, needs investigation. + 'array-sort': [PASS, NO_VARIANTS], + 'dehoisted-array-index': [PASS, NO_VARIANTS], + + # TODO(mstarzinger/rossberg): Typer doesn't like contexts very much. + 'harmony/block-conflicts': [PASS, NO_VARIANTS], + 'harmony/block-for': [PASS, NO_VARIANTS], + 'harmony/block-leave': [PASS, NO_VARIANTS], + 'harmony/block-let-crankshaft': [PASS, NO_VARIANTS], + 'harmony/empty-for': [PASS, NO_VARIANTS], + + # TODO(mstarzinger): Needs more investigation. + 'polymorph-arrays': [PASS, NO_VARIANTS], + 'string-oom-concat': [PASS, NO_VARIANTS], + 'unbox-double-arrays': [PASS, NO_VARIANTS], + 'compiler/osr-warm': [PASS, NO_VARIANTS], + 'compiler/regress-3136962': [PASS, NO_VARIANTS], + 'harmony/proxies-json': [PASS, NO_VARIANTS], + 'regress/regress-3476': [PASS, NO_VARIANTS], + 'regress/regress-760-1': [PASS, NO_VARIANTS], + 'regress/regress-760-2': [PASS, NO_VARIANTS], + 'regress/regress-crbug-357052': [PASS, NO_VARIANTS], + # Some tests are over-restrictive about object layout. 'array-constructor-feedback': [PASS, NO_VARIANTS], 'array-feedback': [PASS, NO_VARIANTS], + 'elements-kind': [PASS, NO_VARIANTS], # Some tests are just too slow to run for now. 'bit-not': [PASS, NO_VARIANTS], diff --git a/test/mozilla/mozilla.status b/test/mozilla/mozilla.status index 592f762..9e8b0af 100644 --- a/test/mozilla/mozilla.status +++ b/test/mozilla/mozilla.status @@ -63,6 +63,9 @@ # TODO(turbofan): Large switch statements crash. 'js1_5/Regress/regress-398085-01': [PASS, NO_VARIANTS], + # TODO(mstarzinger): Typed lowering screws up ToBoolean somehow. + 'ecma/TypeConversion/9.2': [PASS, NO_VARIANTS], + ##################### SKIPPED TESTS ##################### # This test checks that we behave properly in an out-of-memory diff --git a/test/webkit/webkit.status b/test/webkit/webkit.status index c14d5c1..4f00530 100644 --- a/test/webkit/webkit.status +++ b/test/webkit/webkit.status @@ -37,6 +37,13 @@ 'exception-with-handler-inside-eval-with-dynamic-scope': [PASS, NO_VARIANTS], # TODO(turbofan): We run out of stack earlier on 64-bit for now. 'fast/js/deep-recursion-test': [PASS, NO_VARIANTS], + # TODO(mstarzinger): Typed lowering screws up ToBoolean somehow. + 'convert-nan-to-bool': [PASS, NO_VARIANTS], + # TODO(mstarzinger): Causes crash in generated code, needs investigation. + 'dfg-arguments-osr-exit': [PASS, NO_VARIANTS], + 'dfg-arguments-osr-exit-multiple-blocks': [PASS, NO_VARIANTS], + 'dfg-arguments-osr-exit-multiple-blocks-before-exit': [PASS, NO_VARIANTS], + 'dfg-arguments-unexpected-escape': [PASS, NO_VARIANTS], # TODO(bmeurer,svenpanne): Investigate test failure. 'fast/js/toString-number': [SKIP], }], # ALWAYS