From: Julia Lawall Date: Fri, 26 Dec 2014 14:35:45 +0000 (-0800) Subject: leds: Use setup_timer X-Git-Tag: v4.14-rc1~5948^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=137fe48d3956a1acfe1851d07ef1fc30fa405e84;p=platform%2Fkernel%2Flinux-rpi.git leds: Use setup_timer Convert a call to init_timer and accompanying intializations of the timer's data and function fields to a call to setup_timer. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression t,f,d; @@ -init_timer(&t); +setup_timer(&t,f,d); -t.function = f; -t.data = d; // Signed-off-by: Julia Lawall Signed-off-by: Bryan Wu --- diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index dbeebac..291ca45 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -239,9 +239,8 @@ int led_classdev_register(struct device *parent, struct led_classdev *led_cdev) INIT_WORK(&led_cdev->set_brightness_work, set_brightness_delayed); - init_timer(&led_cdev->blink_timer); - led_cdev->blink_timer.function = led_timer_function; - led_cdev->blink_timer.data = (unsigned long)led_cdev; + setup_timer(&led_cdev->blink_timer, led_timer_function, + (unsigned long)led_cdev); #ifdef CONFIG_LEDS_TRIGGERS led_trigger_set_default(led_cdev);