From: Edward Hervey Date: Thu, 22 Jan 2009 04:10:38 +0000 (+0100) Subject: Adding git hooks X-Git-Tag: upstream/20130618~260 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=137543b7e782c811bc88bf9210323e7e75835d18;p=platform%2Fupstream%2Fgst-common.git Adding git hooks --- diff --git a/hooks/pre-commit.hook b/hooks/pre-commit.hook new file mode 100644 index 0000000..34dd510 --- /dev/null +++ b/hooks/pre-commit.hook @@ -0,0 +1,34 @@ +#!/bin/sh +# +# Check that the code follows a consistant code style +# + +# FIXME : Add a check for existence of indent, and return 0 if not present + +echo "--Checking style--" +for file in `git-diff-index --name-only HEAD | grep "\.c$"` ; do +tempfoo=`basename $0` + newfile=`mktemp /tmp/${tempfoo}.XXXXXX` || exit 1 + indent \ + --braces-on-if-line \ + --case-brace-indentation0 \ + --case-indentation2 \ + --braces-after-struct-decl-line \ + --line-length80 \ + --no-tabs \ + --cuddle-else \ + --dont-line-up-parentheses \ + --continuation-indentation4 \ + --honour-newlines \ + --tab-size8 \ + --indent-level2 \ + $file -o $newfile 2>> /dev/null + diff -u -p "${file}" "${newfile}" + r=$? + rm "${newfile}" + if [ $r != 0 ] ; then +echo "Code style error in $file, please fix before commiting." + exit 1 + fi +done +echo "--Checking style pass--" diff --git a/hooks/pre-receive.hook b/hooks/pre-receive.hook new file mode 100644 index 0000000..8ddcd87 --- /dev/null +++ b/hooks/pre-receive.hook @@ -0,0 +1,76 @@ +#!/usr/bin/env python +import sys +import os +import subprocess + +# This server-side pre-receive hook is to be put and activated in all modules +# that depend on the common submodule. +# +# It will check whether any modifications to the common 'submodule file' has a +# a valid commit SHA1 that exists in the common module. + +def commit_exists(sha1, gitdir): + """Returns True if the sha1 is a valid commit in the given + git directory""" + # FIXME: We're using git-show for the time being, but there's a small + # risk that there might be a valid SHA1 for a non-commit object. + env = os.environ.copy() + env["GIT_DIR"] = gitdir + sub = subprocess.Popen(["git", "show", sha1], env=env, + stdout=subprocess.PIPE, + stderr=subprocess.PIPE) + while True: + res = sub.poll() + if res != None: + return res == 0 + +# location of the common git module +COMMON_GIT_DIR = "/git/gstreamer/common.git" + +pushvalid = True + +print "=> Checking for integrity of common submodule changes" +print + +for line in sys.stdin.readlines(): + # ref is the ref to be modified + # old is the old commit it was pointing to + # new is the new commit it was pointing to + old, new, ref = line.split(' ', 2) + + # 1. Get the latest change to common (if there was any changes) + sub = subprocess.Popen(["git-diff", "%s..%s" % (old, new, ), "--", "common"], + stdout=subprocess.PIPE) + stdout, stderr = sub.communicate() + if stdout != "": + # Format of submodule special files + # Subproject commit + + # we get a diff, therefore only grab the last line + lastline = stdout.strip().rsplit('\n',1)[-1] + if not lastline.startswith("+Subproject commit"): + # this is bad, it means the diff has changed to something completely + # different + continue + subsha1 = lastline.rsplit(' ', 1)[-1] + print " Pack wants common to point to", subsha1 + if not commit_exists(subsha1, COMMON_GIT_DIR): + print " /!\\ Commit does not exist in common git module /!\\" + print " /!\\ for ref", ref + pushvalid = False + break + + # 2. Figure out if that commit exists in the common submodule + # (use GIT_DIR to execute commands in that directory) + +if pushvalid: + print " Incoming packet valid, proceeding to actual commit" + sys.exit(0) +else: + print " Attempting to push commits containing modifications to common" + print " that have not been commited to the actuall common module." + print + print " First push your changes to common/ before pushing the changes" + print " to the module using it." + sys.exit(-1) +