From: Qinglang Miao Date: Fri, 27 Nov 2020 09:44:44 +0000 (+0800) Subject: drm: rcar-du: Fix PM reference leak in rcar_cmm_enable() X-Git-Tag: v5.15~1634^2~24^2~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=136ce7684bc1ff4a088812f600c63daca50b32c2;p=platform%2Fkernel%2Flinux-starfive.git drm: rcar-du: Fix PM reference leak in rcar_cmm_enable() pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in [0] to keep usage counter balanced. So We fix the reference leak by replacing it with new funtion. [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: e08e934d6c28 ("drm: rcar-du: Add support for CMM") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao Acked-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- diff --git a/drivers/gpu/drm/rcar-du/rcar_cmm.c b/drivers/gpu/drm/rcar-du/rcar_cmm.c index c578095..382d53f 100644 --- a/drivers/gpu/drm/rcar-du/rcar_cmm.c +++ b/drivers/gpu/drm/rcar-du/rcar_cmm.c @@ -122,7 +122,7 @@ int rcar_cmm_enable(struct platform_device *pdev) { int ret; - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) return ret;