From: Patrick McHardy Date: Tue, 19 Jan 2010 18:06:59 +0000 (+0100) Subject: netfilter: nf_conntrack_sip: fix off-by-one in compact header parsing X-Git-Tag: upstream/snapshot3+hdmi~15639^2~39^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=135d01899b1fba17045961febff7e5141db6048f;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git netfilter: nf_conntrack_sip: fix off-by-one in compact header parsing In a string like "v:SIP/2.0..." it was checking for !isalpha('S') when it meant to be inspecting the ':'. Patch by Greg Alexander Signed-off-by: Patrick McHardy --- diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c index 4b57216..023966b 100644 --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c @@ -376,7 +376,7 @@ int ct_sip_get_header(const struct nf_conn *ct, const char *dptr, dptr += hdr->len; else if (hdr->cname && limit - dptr >= hdr->clen + 1 && strnicmp(dptr, hdr->cname, hdr->clen) == 0 && - !isalpha(*(dptr + hdr->clen + 1))) + !isalpha(*(dptr + hdr->clen))) dptr += hdr->clen; else continue;