From: Lukasz Bardeli Date: Wed, 5 Dec 2018 09:18:08 +0000 (+0100) Subject: [MessagePort] Fixed issue with removeMessagePortListener without any added earlier X-Git-Tag: submit/tizen/20190109.233706^2~5^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=134692c2a052dc095bc7daf0ee6478b5eba673b6;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git [MessagePort] Fixed issue with removeMessagePortListener without any added earlier If any listener was added before remove then error was thrown 'Cannot read property length of undefined' [Verification] Code compiles without error. TCT passrate 100% Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b Signed-off-by: Lukasz Bardeli --- diff --git a/src/messageport/messageport_api.js b/src/messageport/messageport_api.js index 283521ad..3219ed2f 100755 --- a/src/messageport/messageport_api.js +++ b/src/messageport/messageport_api.js @@ -185,10 +185,10 @@ LocalMessagePort.prototype.removeMessagePortListener = function(watchId) { var toDelete; var listeners = callbacks[ports[this.messagePortName]]; - for (var i = 0, j = listeners.length; i < j; i++) { - var listenerId = listeners[i][1]; + for (var key in listeners) { + var listenerId = listeners[key][1]; if (watchId == listenerId) { - toDelete = i; + toDelete = key; break; } }