From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 6 Feb 2013 20:27:18 +0000 (+0100)
Subject: qmp: Plug memory leaks in memchar-write, memchar-read
X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~2598
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=13289fb5a716e06fb06febb880e5e116d485f82b;p=sdk%2Femulator%2Fqemu.git

qmp: Plug memory leaks in memchar-write, memchar-read

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/qemu-char.c b/qemu-char.c
index b1c6132..4dd01e6 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2782,6 +2782,10 @@ void qmp_memchar_write(const char *device, const char *data,
 
     ret = cirmem_chr_write(chr, write_data, write_count);
 
+    if (write_data != (uint8_t *)data) {
+        g_free((void *)write_data);
+    }
+
     if (ret < 0) {
         error_setg(errp, "Failed to write to device %s", device);
         return;
@@ -2825,6 +2829,7 @@ char *qmp_memchar_read(const char *device, int64_t size,
 
     if (has_format && (format == DATA_FORMAT_BASE64)) {
         data = g_base64_encode(read_data, size);
+        g_free(read_data);
     } else {
         data = (char *)read_data;
     }