From: Alessandro Zummo <a.zummo@towertech.it>
Date: Thu, 3 Apr 2014 21:50:09 +0000 (-0700)
Subject: rtc: verify a critical argument to rtc_update_irq() before using it
X-Git-Tag: accepted/tizen/common/20141203.182822~309^2~34
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=131c9cc832162bfe45be1065fa88d1ec2c165a3d;p=platform%2Fkernel%2Flinux-arm64.git

rtc: verify a critical argument to rtc_update_irq() before using it

This small addition to the core simplifies code in the drivers and makes
them more robust when handling shared IRQs.

Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexander Shiyan <shc_work@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
index 544be72..c2eff60 100644
--- a/drivers/rtc/interface.c
+++ b/drivers/rtc/interface.c
@@ -584,6 +584,9 @@ enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer)
 void rtc_update_irq(struct rtc_device *rtc,
 		unsigned long num, unsigned long events)
 {
+	if (unlikely(IS_ERR_OR_NULL(rtc)))
+		return;
+
 	pm_stay_awake(rtc->dev.parent);
 	schedule_work(&rtc->irqwork);
 }