From: Pan Bian Date: Sun, 23 Apr 2017 09:26:45 +0000 (-0300) Subject: [media] m5602_s5k83a: check return value of kthread_create X-Git-Tag: v4.13-rc4~5^2~387 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=13174c388a76005c1abe454e47a37cd57edd8c8d;p=platform%2Fkernel%2Flinux-exynos.git [media] m5602_s5k83a: check return value of kthread_create Function kthread_create() returns an ERR_PTR on error. However, in function s5k83a_start(), its return value is used without validation. This may result in a bad memory access bug. This patch fixes the bug. Signed-off-by: Pan Bian Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c index be5e25d1..6ad8d48 100644 --- a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c +++ b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c @@ -345,6 +345,11 @@ int s5k83a_start(struct sd *sd) to assume that there is no better way of accomplishing this */ sd->rotation_thread = kthread_create(rotation_thread_function, sd, "rotation thread"); + if (IS_ERR(sd->rotation_thread)) { + err = PTR_ERR(sd->rotation_thread); + sd->rotation_thread = NULL; + return err; + } wake_up_process(sd->rotation_thread); /* Preinit the sensor */